Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add testing instructions in CONTRIBUTING.md #292

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

cjdcordeiro
Copy link
Collaborator

@cjdcordeiro cjdcordeiro commented Jul 24, 2024

Proposed changes

Ensure the Spread testing instructions are part of the contributing guidelines, and that the PR description template is also updated accordingly.

Related issues/PRs

#281
#290
#289

Checklist

@cjdcordeiro cjdcordeiro requested a review from a team July 24, 2024 10:03
@cjdcordeiro cjdcordeiro self-assigned this Jul 24, 2024
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me for the most part. Just a bunch of nitpicks below.

.github/pull_request_template.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@cjdcordeiro cjdcordeiro requested review from rebornplusplus and a team July 24, 2024 11:45
@cjdcordeiro cjdcordeiro requested a review from a team July 25, 2024 14:03
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one question:

.github/workflows/spread.yaml Outdated Show resolved Hide resolved
@cjdcordeiro cjdcordeiro merged commit 4cf1397 into canonical:main Jul 26, 2024
1 check passed
clay-lake pushed a commit to clay-lake/chisel-releases that referenced this pull request Nov 18, 2024
clay-lake pushed a commit to clay-lake/chisel-releases that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants